Enable unwinding in userspace #1098
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for aya-rs-docs processing.
|
tamird
changed the title
tamird
force-pushed
the
cleanup
branch
17 times, most recently
from
acd80cf
to
0887c71
Compare
tamird
force-pushed
the
cleanup
branch
7 times, most recently
from
5aefd0c
to
fc37b43
Compare
|
@tamird, this pull request is now in conflict and requires a rebase. |
The panic has been fixed.
The const-assert crate doesn't even compile with stable rust, so we shouldn't depend on it. Instead we replicate its functionality behind cfg(unstable) which is set at build time based on the toolchain in use.
Unwinding gives us more information, so we shouldn't disable it globally. It is already disabled for BPF targets via the target configs in rustc itself. This complicates the clippy invocation somewhat, so put it in a shell script for developer as well as CI use.
Centralize the knowledge in build.rs instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
This change is