-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update submodules #89
Conversation
- name: Setup dotnet | ||
uses: actions/setup-dotnet@v3 | ||
with: | ||
dotnet-version: '5.0.x' | ||
- uses: ilammy/msvc-dev-cmd@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not your fault, but
ilammy/msvc-dev-cmd
<-- in my experience, this github action has no effect
it ended up in all our ci.yml files when we were first setting up our repos and copy/pasting everything
later we discovered it had no effect, but we've never made a concerted effort to fix this across our 20+ repos :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -110,6 +114,10 @@ jobs: | |||
matrix: | |||
arch: [x86, x64] | |||
steps: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not your fault, but this "windows-vc14" run isn't doing what it claims.
vc14 means version 14.0 of the compiler, aka toolset 140, which came with Visual Studio 2015, but you can still use those older toolset versions with later versions of Visual Studio
but it's actually just using the default compiler on this machine, which is Visual Studio 2019's version 14.29
Here's the line in the logs where you see what it's actually using.
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x86/cl.exe
and then you cross-reference that against the Wikipedia page that details what the hell those version numbers mean. And you see that 14.29 means it's the latest build Visual Studio 2019 compiler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a TODO for now.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.