Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update package name OSX #4923

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

chore: update package name OSX #4923

wants to merge 5 commits into from

Conversation

dougch
Copy link
Contributor

@dougch dougch commented Nov 21, 2024

Release Summary:

Resolved issues:

#4922

Description of changes:

Upstream issue actions/runner-images#10984 - comment is that a migration will happen next week, marking this check optional.

The macos-latest needs to be updated, or we need to pin to an older ver 14.7.

Call-outs:

Address any potentially confusing code. Is there code added that needs to be cleaned up later? Is there code that is missing because it’s still in development? If a callout is specific to a section of code, it might make more sense to leave a comment on your own PR file diff.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? What manual testing was performed? Are there any testing steps to be verified by the reviewer?
How can you convince your reviewers that this PR is safe and effective?
Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed?

Remember:

  • Any change to the library source code should at least include unit tests.
  • Any change to the core stuffer or blob methods should include CBMC proofs.
  • Any change to the CI or tests should:
    1. prove that the test succeeds for good input
    2. prove that the test fails for bad input (eg, a test for memory leaks fails when a memory leak is committed)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dougch dougch marked this pull request as ready for review November 21, 2024 17:48
@dougch dougch changed the title chore: update package name chore: update package name OSX Nov 22, 2024
@dougch dougch marked this pull request as draft November 22, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant