Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomCallOp unsupported target: TopK on Llama 3.1 with topk=2 #1025

Open
steeve opened this issue Nov 4, 2024 · 1 comment
Open

CustomCallOp unsupported target: TopK on Llama 3.1 with topk=2 #1025

steeve opened this issue Nov 4, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@steeve
Copy link

steeve commented Nov 4, 2024

Hi,

Our (@zml) Llama implementation fails to compile if we run with topk > 1.
We're not sure what triggers it, it looks like some pattern matching.

Please find attached our implementation with topk=2.

Thanks!!

error(pjrt): [PJRT_Client_Compile] RunNeuronCCImpl: error condition error != 0: <class 'subprocess.CalledProcessError'>: Command '['neuronx-cc', 'compile', '--framework=XLA', '--target=trn1', '--verbose=35', '--output=/tmp/tmpqle33ids/file.neff', '/tmp/tmpqle33ids/file.code', '--model-type=transformer', '--auto-cast=none']' returned non-zero exit status 70.

llama.mlir.txt

@steeve steeve changed the title CustomCallOp unsupported target: TopK CustomCallOp unsupported target: TopK on Llama 3.1 with topk=2 Nov 4, 2024
@nalwayaakshay
Copy link

Hi,

For debugging it further, could you please share your source code and/or the HLO file generated which is causing compiler error?

@aws-taylor aws-taylor added the bug Something isn't working label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants