Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to specify UsePreviousValue #46

Open
edmacdonald opened this issue Nov 12, 2020 · 1 comment
Open

How to specify UsePreviousValue #46

edmacdonald opened this issue Nov 12, 2020 · 1 comment

Comments

@edmacdonald
Copy link

Is there a way to specify UsePreviousValue for parameter-overrides provided in-line rather than in a file?

In my case, some of the parameters are determined by the build (eg product version) and some maintained by operations (eg min/max ASG size). I want to UsePreviousValue for the ops params. The build param values are generated by build steps and are quite convenient to use inline.

Thanks,
-Ed

@pbrisbin
Copy link

pbrisbin commented May 1, 2021

I found this issue because I am currently a little frustrated that that's not just how unspecified parameters work.

I have a deployed Stack named prod-services with existing values:

And I'm trying to deploy a change to one of them:

      - uses: aws-actions/aws-cloudformation-github-deploy@v1
        with:
          name: prod-services
          template: https://s3.amazonaws.com/infra.restyled.io/templates/prod/services.yaml
          parameter-overrides: "RestylerImage=${{ needs.image.outputs.image }}"
          no-execute-changeset: 1

And I'm getting the following errors:

The input is parameter-overrides, so I think it's reasonable to expect behavior of the analogous flag:

       --parameter-overrides  (string)  A  list  of  parameter structures that
       specify input parameters for your stack template. If you're updating  a
       stack  and  you don't specify a parameter, the command uses the stack's
       existing value. For new stacks, you must specify parameters that  don't
       have  a  default  value.  ...

I'd argue the current behavior, which is more like the --parameters options of (create|update)-stack, is a clear bug.

Is there something I'm missing here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants