Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer has invalid references to GitHub repos #106

Open
peterrakolcza opened this issue Apr 26, 2022 · 2 comments
Open

Installer has invalid references to GitHub repos #106

peterrakolcza opened this issue Apr 26, 2022 · 2 comments

Comments

@peterrakolcza
Copy link

Hey!

I have found several invalid references to GitHub repos while I was trying to install avatar2.

When I try to run python -m avatar2.installer, most targets, that are available from the package manager, install without a problem, however, others exited when the installer had tried to clone the given repos.

After debugging a little, I found out that branches for the targets' repos have been changed!

@mariusmue
Copy link
Member

Hi!

Thanks for reporting! Indeed, we have changed our development over to docker, and rarely use the installer these days. I see two ways forward:

  1. fixing the references and bringing the installer up to date
  2. Deprecating the installer and be more detailed about our dockerized setup

Personally, I would prefer (2), I think - unless someone wants to take over the installer feature. @rawsample what is your opinion?

@rawsample
Copy link
Member

Hello,

I agree with you, the docker approach is more robust and should be prioritize for targets installation.
We can deprecate the installer.
Nevertheless, bringing it up to date was not a huge effort. I will commit this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants