Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remote monitoring integration steps from Interplai #347

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

raminterpl
Copy link
Contributor

Description

Integration of Remote monitoring steps and interfaces required to do the remote monitoring.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

raminterpl and others added 2 commits April 4, 2023 16:25
It describes the integration of Remote monitoring steps and interfaces required to do the remote monitoring.
@raminterpl raminterpl changed the title docs: Remote monitoring integration steps from Interplai docs: remote monitoring integration steps from Interplai Apr 4, 2023
@raminterpl raminterpl requested a review from xmfcx April 4, 2023 11:07
@raminterpl raminterpl self-assigned this Apr 4, 2023
@stale
Copy link

stale bot commented Jun 8, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jun 8, 2023
Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this documentation, it looks quite comprehensive on how to use your solution. I hope it will be helpful to the people using it.

I'm sorry for taking so long to review this.
I've made many small grammatical suggestions. I hope it helps.

@@ -0,0 +1,52 @@
​ **Autoware Interplai Teleoperation Design**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Autoware Interplai Teleoperation Design**
# Autoware Interplai Teleoperation Design

@@ -0,0 +1,52 @@
​ **Autoware Interplai Teleoperation Design**

**Remote Monitoring - Architecture:**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Remote Monitoring - Architecture:**
## Remote Monitoring - Architecture


![image-20230404160609015](/home/dark/snap/typora/78/.config/Typora/typora-user-images/image-20230404160609015.png)

**Phase – 1 (Remote monitoring):**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Phase – 1 (Remote monitoring):**
### Phase – 1 (Remote monitoring)


**Phase – 1 (Remote monitoring):**

**On Vehicle Side:**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**On Vehicle Side:**
#### On Vehicle Side


- Communicate with the signaling server, hosted on (ex: AWS, GCP) where Vehicle ID can get registered

**Dash board:**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Dash board:**
##### Dashboard

for ex: WebRTCDataTransferNode
- Gstream pipeline for gathering video data from 4 cameras and audio from 1 microphone
- Data channel for transmitting/ receiving control commands
- Registering the vehicle ID on signaling server (communication medium)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Registering the vehicle ID on signaling server (communication medium)
- Register the vehicle ID on the signaling server (communication medium).


- Integrate ROS2 node (WebRTCDataTransferNode) inside launch file of Autoware Universe

- Communicate with the signaling server, hosted on (ex: AWS, GCP) where Vehicle ID can get registered
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Communicate with the signaling server, hosted on (ex: AWS, GCP) where Vehicle ID can get registered
- Communicate with the signaling server, hosted on (e.g. AWS, GCP) where the Vehicle ID can get registered.

e.g. is preferred over ex::


- Option to choose the remote monitoring on web page

- ID mapping between vehicle and remote operator happens on signaling server , to allow only authenticated access
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- ID mapping between vehicle and remote operator happens on signaling server , to allow only authenticated access
- ID mapping between vehicle and remote operator happens on signaling server, to allow only authenticated access.


- ID mapping between vehicle and remote operator happens on signaling server , to allow only authenticated access

- Disconnect button for closing the remote monitoring
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Disconnect button for closing the remote monitoring
- Disconnect button to close the remote monitoring.

Application: Tele-operation for parking lot

Vehicle to Infrastructure communication
-5G Modem(simcom,quectel)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-5G Modem(simcom,quectel)
- 5G Modem (e.g. SIMCom, Quectel)

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Jun 8, 2023
@xmfcx xmfcx removed their assignment Jun 8, 2023
@xmfcx xmfcx added tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. component:system System design and integration. labels Jun 8, 2023
@xmfcx
Copy link
Contributor

xmfcx commented Jun 8, 2023

Also for the file name, can you consider following the convention from the other files in the folder?

https://github.com/autowarefoundation/autoware-documentation/tree/main/docs/design/autoware-interfaces/components

teleoperation.md should be enough for the file name.

@stale
Copy link

stale bot commented Aug 7, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. status:stale Inactive or outdated issues. (auto-assigned) tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants