You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current API implementation will use toId() to convert nation names before submitting a request.
The implementation of toId is however slightly flawed: for a nation Foo_ it will return foo instead of the expected foo_.
This is an edge case, as there is currently only two nations in the world ending with an underscore (and none starting with one).
The obvious fix is to trim only whitespace, not underscores as well.
The text was updated successfully, but these errors were encountered:
dithpri
added a commit
to dithpri/node-nsapi
that referenced
this issue
Dec 12, 2021
The current API implementation will use
toId()to convert nation names before submitting a request.The implementation of
toIdis however slightly flawed: for a nationFoo_it will returnfooinstead of the expectedfoo_.This is an edge case, as there is currently only two nations in the world ending with an underscore (and none starting with one).
The obvious fix is to trim only whitespace, not underscores as well.
The text was updated successfully, but these errors were encountered: