You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Atuin shouldn't crash just because the I'm using non-unicode bytes in filepaths
What happened?
With atuin installed, run:
mkdir $'\xff'cd$'\xff'
I get the following stacktrace:
thread 'main' panicked at library/std/src/env.rs:171:83:
called `Result::unwrap()` on an `Err` value: "/home/user/chess/\xFF"
stack backtrace:
0: rust_begin_unwind
1: core::panicking::panic_fmt
2: core::result::unwrap_failed
3: <std::env::Vars as core::iter::traits::iterator::Iterator>::next
4: <config::env::Environment as config::source::Source>::collect
5: config::source::Source::collect_to
6: <[alloc::boxed::Box<dyn config::source::Source+core::marker::Send+core::marker::Sync>] as config::source::Source>::collect
7: config::builder::ConfigBuilder<config::builder::DefaultState>::build_internal
8: config::builder::ConfigBuilder<config::builder::DefaultState>::build
9: atuin_client::settings::Settings::new
10: atuin::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
It looks like the bug is caused by this env::vars() line, which crashes atuin if any environment variable (in this case PWD) contains non-unicode characters:
What did you expect to happen?
Atuin shouldn't crash just because the I'm using non-unicode bytes in filepaths
What happened?
With atuin installed, run:
I get the following stacktrace:
Atuin doctor output
Code of Conduct
The text was updated successfully, but these errors were encountered: