From c44b2934578346891a1f18a1ed2e0d24c97b8b58 Mon Sep 17 00:00:00 2001 From: Andy Teucher Date: Sun, 7 Jul 2024 14:47:56 -0700 Subject: [PATCH] fix numeric version check in a couple more places --- tests/testthat/helpers.R | 2 +- tests/testthat/test-clip_erase.R | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/testthat/helpers.R b/tests/testthat/helpers.R index cbccbf7..8ab71cd 100644 --- a/tests/testthat/helpers.R +++ b/tests/testthat/helpers.R @@ -3,7 +3,7 @@ has_sys_mapshaper <- function() { } skip_on_old_v8 <- function() { - if (v8_version() < 6) { + if (v8_version() < "6") { testthat::skip("Skipping due to old V8 engine") } } diff --git a/tests/testthat/test-clip_erase.R b/tests/testthat/test-clip_erase.R index 8a2417a..e535e67 100644 --- a/tests/testthat/test-clip_erase.R +++ b/tests/testthat/test-clip_erase.R @@ -200,7 +200,7 @@ test_that("clip and erase fail properly", { }) test_that("ms_clip and ms_erase fail with old v8", { - skip_if_not(v8_version() < 6, "Not old v8") + skip_if_not(v8_version() < "6", "Not old v8") expect_error(ms_clip(ce_poly, ce_inner_poly)) expect_error(ms_erase(ce_poly, ce_inner_poly)) })