-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
why we do not use message name in v3 conversion #195
Comments
also in case of:
instead of
can't we convert to
|
Yes, |
it is combining operationId with suffix index atm, or operation name if id is missing. My suggestion is that I had to rework many examples, as these message names from converter were really not readable - not to say useless |
as described in https://github.com/asyncapi/converter-js#conversion-2xx-to-3xx
Why we do not take into account
name
of the message, because it can be duplicated across operations (not unique likemessageId
)? If we see duplication, we can have the same approach as described above, with index.Or am I something missing
Currently in case of this 2.x example:
resulting message name in a new v3 channel is:
and better would be
or in some cases:
cc @jonaslagoni @magicmatatjahu
The text was updated successfully, but these errors were encountered: