Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added ui/ux improvements in optimize commands #1526

Merged
merged 6 commits into from
Oct 26, 2024
Merged

chore: added ui/ux improvements in optimize commands #1526

merged 6 commits into from
Oct 26, 2024

Conversation

Vishalk91-4
Copy link
Contributor

Description

  • Added UI Functionality Chnges in the Optimize Command
  • image
  • image
  • image

Related issue(s)

Resolves #1383

@Souvikns
Copy link
Member

Hi @Vishalk91-4 thanks for opening this PR, can you update the PR title following https://www.conventionalcommits.org/en/v1.0.0/.

@Vishalk91-4 Vishalk91-4 changed the title Added UI Changes to Optimize Command chore: added ui/ux improvements in optimize commands Sep 24, 2024
@Vishalk91-4
Copy link
Contributor Author

Hi @Vishalk91-4 thanks for opening this PR, can you update the PR title following https://www.conventionalcommits.org/en/v1.0.0/.

@Souvikns Made the Changes, PTAL

@Souvikns
Copy link
Member

@Vishalk91-4 you have some tests failing, just update the tests according to the changes that you are introducing.

@Vishalk91-4
fix: failing tests
89ec46d 
Signed-off-by: Vishal K <korada.vishal.phe22@itbhu.ac.in>
@Vishalk91-4
Copy link
Contributor Author

@Vishalk91-4 you have some tests failing, just update the tests according to the changes that you are introducing.

Fixed those errors

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Souvikns Souvikns merged commit 4627ea5 into asyncapi:master Oct 26, 2024
21 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Souvikns Souvikns Souvikns approved these changes

@Amzani Amzani Awaiting requested review from Amzani Amzani is a code owner

@Shurtu-gal Shurtu-gal Awaiting requested review from Shurtu-gal Shurtu-gal is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
released
Projects
CLI - Kanban
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement new UI/UX improvements in optimize command
3 participants
@Vishalk91-4 @Souvikns @asyncapi-bot