WPS rule implementation

[Lokejoke]

I've implemented some of the wps's opinionated rules.
I would really appreciate any feedback.

plugin	rule and PR ref	code (docs)	PR ref
wps-light	consecutive-underscores-in-name	WPS116	(PR ref)
wps-light	reserved-argument-as-variable	WPS117	(PR ref)
wps-light	unused-variable-accessed	WPS121	(PR ref)
wps-light	underscores-in-number	WPS303	(PR ref)
wps-light	assignment-to-subscript-slice	WPS362	(PR ref)
wps-light	list-multiplication	WPS435	(PR ref)
wps-light	getter-without-return-value	WPS463	(PR ref)
wps-light	in-compare-with-single-item-container	WPS525	(PR ref)
wps-light	wrong-class-body-content	WPS604	(PR ref)

• would any fit inside ruff?

[MichaReiser]

Oh wow, nice. #3845 is the related tracking issue

The reason we haven't added any wemake styleguide rules yet is that many of them are very opinionated and sometimes overlap or even conflict with the formatter. But that doesn't apply to all the rules.

After doing a quick scan over the listed rules:

• list-multiplication: Related to Add new rule to prevent nested list footgun #10505
• [wps-light] Implement in-compare-with-single-item-container (WPS525) Lokejoke/ruff#11 seems reasoanble, but it's unclear how common this is.
• wrong-class-body-content: Seems reasonable
• [wps-light] Implement unused-variable-accessed (WPS121) Lokejoke/ruff#8 looks useful

The other rules seem a bit on the too opinionated end (IMO)

[Lokejoke]

I agree. I'll reformat those four as separate Ruff rules and submit an individual PR for each. This way, we can easily discard any that turn out to be unnecessary. (I wanted to avoid spamming the PR section)

Does that sound good?

[MichaReiser]

That sounds good. It may take some time for us to get to review the new rules because we're currently busy with prepping for the next rough release. Thanks for asking before creating that many PRs :)

One thing we'll have to decide that's relevant for all rules is whether we want to add a wemake styleguide group or add the rules under the ruff prefix.