Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve test flakiness #1017

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

eddbbt
Copy link
Contributor

@eddbbt eddbbt commented Nov 21, 2024

This PR aims to resolve flakiness for trigger_engine tests (due to a delay in data synchronization) and realm_management_api test (due to a flaw in tests setup)

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.48%. Comparing base (d8bfac8) to head (6b3dd4a).
Report is 15 commits behind head on release-1.1.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.1    #1017       +/-   ##
================================================
+ Coverage        68.05%   82.48%   +14.43%     
================================================
  Files              281       71      -210     
  Lines             7428     1730     -5698     
================================================
- Hits              5055     1427     -3628     
+ Misses            2373      303     -2070     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@eddbbt eddbbt changed the base branch from master to release-1.1 November 21, 2024 16:39
@eddbbt eddbbt changed the title fix jwt Resolve test flakiness Nov 22, 2024
@eddbbt eddbbt force-pushed the resolve-flakiness branch 2 times, most recently from be29c8b to 32e1510 Compare November 22, 2024 09:39
@eddbbt eddbbt marked this pull request as ready for review November 22, 2024 09:46
Fix realm_management_api tests for triggerController adding a proper realm setup
Resolves :jose_jwk.from_pem/1 not found error

Signed-off-by: Eddy Babetto <eddy.babetto@secomind.com>
ix trigger_engine amqp_consumer tracker tests adding a sleep before checks
Resolves registry not found that sometimes used to arise, caused by an amqp delay

Signed-off-by: Eddy Babetto <eddy.babetto@secomind.com>
@Annopaolo Annopaolo merged commit 0604ac5 into astarte-platform:release-1.1 Nov 22, 2024
29 checks passed
This was referenced Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants