Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple Build Issues on Ninja #8

Open
N0tACyb0rg opened this issue Sep 26, 2020 · 4 comments
Open

Multiple Build Issues on Ninja #8

N0tACyb0rg opened this issue Sep 26, 2020 · 4 comments

Comments

@N0tACyb0rg
Copy link

Hello!
When building using the directions with Clang installed, I get a fail because of too many errors from the code. I have run everything according to the compilation directions.
Pastebin Link: Link
@trsoluti
Copy link

Had same problem but then ran tools/install_dependencies.sh as recommended by Skia site, and now can compile.

@N0tACyb0rg
Copy link
Author

Forgot to mention I am building on Windows.

@N0tACyb0rg
Copy link
Author

Will investigate anyways

@N0tACyb0rg
Copy link
Author

install_dependencies.sh did not work. The window said unrecognized system.

dacap pushed a commit that referenced this issue Nov 4, 2021
@herbderby
fix deadlock in remote cache logging
6bc9626 
In the stack trace in the bug, #16 findOrCreateStrike() grabs the
lock, and then #8 Dump() makes calls that grab the lock. This is
only a problem with debug code.

Bug: chromium:1255085

Change-Id: Idcaad8bf2e8c2823bec899ee2b96a74ae666c164
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/455501
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
dacap pushed a commit that referenced this issue May 15, 2023
@johnstiles-google
Reorder struct for better Neon codegen.
8822608 
I unexpectedly discovered that we can reduce our splat-copy ops
by one instruction by swapping these struct fields. This is
apparently because we can wedge a right-shift by 32 into an add
instruction. (`uxtw` means zero-extend.)

Before (splat_2_constants):
    bcf4: 28 04 40 f9  	ldr	x8, [x1, #8]
    bcf8: 09 fd 60 d3  	lsr	x9, x8, #32          <--- eliminated
    bcfc: 30 01 27 1e  	fmov	s16, w9
    bd00: 10 06 04 4e  	dup.4s	v16, v16[0]
    bd04: 88 40 28 8b  	add	x8, x4, w8, uxtw     <--- changed
    bd08: 10 41 00 ad  	stp	q16, q16, [x8]
    bd0c: 25 0c 41 f8  	ldr	x5, [x1, #16]!
    bd10: a0 00 1f d6  	br	x5

After:
    baa0: 28 04 40 f9  	ldr	x8, [x1, #8]
    baa4: 10 01 27 1e  	fmov	s16, w8
    baa8: 10 06 04 4e  	dup.4s	v16, v16[0]
    baac: 88 80 48 8b  	add	x8, x4, x8, lsr #32
    bab0: 10 41 00 ad  	stp	q16, q16, [x8]
    bab4: 25 0c 41 f8  	ldr	x5, [x1, #16]!
    bab8: a0 00 1f d6  	br	x5

(This also saves an op on Haswell!)

Change-Id: Icea7196b42bc4057d697bbf049d368193d46f27e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/679719
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trsoluti @N0tACyb0rg