Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"skip rejected" fails when focus on candidate image listbox #4

Open
asalmon91 opened this issue Aug 13, 2018 · 4 comments
Open

"skip rejected" fails when focus on candidate image listbox #4

asalmon91 opened this issue Aug 13, 2018 · 4 comments
Assignees

Comments

@asalmon91
Copy link
Owner

If you click on one of the candidate images, rather than using the arrow keys, the default behavior of skipping rejected images fails. I believe this can be circumvented by changing the focus to a different UI element, but skipping rejected images should be the behavior regardless of the focus.

@asalmon91 asalmon91 self-assigned this Aug 13, 2018
@jecava
Copy link

jecava commented Sep 10, 2020

I actually prefer being able to see rejected images sometimes, because occasionally I will accidentally reject an image I want.

@asalmon91
Copy link
Owner Author

Would it make more sense to remove the "skip rejected" feature? It was designed to reduce button presses, but if it adds confusion, then it might not be worthwhile.

@jecava
Copy link

jecava commented Sep 10, 2020

I think it would make sense to remove it, as the skipping is disorienting and in most cases does not reduce the button presses since the rejected images are usually at the bottom of the list anyway.

@asalmon91
Copy link
Owner Author

Awesome, thanks for the feedback! I will hopefully have some time to address these issues starting January 2021.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants