Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE - chore: removing old chat code and cleaning up complexity #14811

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Mitch-Henson
Copy link
Contributor

@Mitch-Henson Mitch-Henson commented Nov 6, 2024

The type of this PR is: CHORE

This PR solves AMBER-1102

Description

🚨 THIS CANNOT BE MERGED UNTIL NEW MESSAGING HAS BEEN TOGGLED ON IN PRODUCTION SUCCESSFULLY 🚨

This will remove the separate paths added in #14783 as part of ensuring a smooth release for the updated Salesforce Messaging widget, in addition to removing the deprecated chat.

@Mitch-Henson Mitch-Henson requested a review from a team November 6, 2024 13:13
@Mitch-Henson Mitch-Henson self-assigned this Nov 6, 2024
jpotts244
jpotts244 previously approved these changes Nov 11, 2024
Copy link
Contributor

@jpotts244 jpotts244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fire when ready 🙏🏻

Copy link

relativeci bot commented Nov 28, 2024

#1089 Bundle Size — 9.57MiB (+0.23%).

1a64b1d(current) vs ffe4f84 main#484(baseline)

Important

Bundle introduced 1 and removed 4 duplicate packages – View changed duplicate packages

Warning

Bundle introduced 3 new packages: web-vitals, @sentry-internal/browser-utils, stylis – View changed packages

Bundle metrics  Change 8 changes Regression 1 regression Improvement 3 improvements
                 Current
#1089
     Baseline
#484
Improvement  Initial JS 3.72MiB(-5.89%) 3.95MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 90.84% 2.04%
No change  Chunks 143 143
Change  Assets 147(+0.68%) 146
Change  Modules 5707(+1.24%) 5637
Regression  Duplicate Modules 496(+9.01%) 455
Change  Duplicate Code 5.85%(-0.51%) 5.88%
Improvement  Packages 282(-3.09%) 291
Improvement  Duplicate Packages 39(-7.14%) 42
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#1089
     Baseline
#484
Regression  JS 9.36MiB (+0.47%) 9.31MiB
Improvement  Other 214.99KiB (-9.61%) 237.84KiB

Bundle analysis reportBranch chore/AMBER-1102/remove-old-chatProject dashboard


Generated by RelativeCIDocumentationReport issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants