Skip to content
This repository has been archived by the owner on Dec 27, 2023. It is now read-only.

Add more targets to verify workflow #78

Open
g4s8 opened this issue Nov 22, 2021 · 4 comments
Open

Add more targets to verify workflow #78

g4s8 opened this issue Nov 22, 2021 · 4 comments

Comments

@g4s8
Copy link
Member

g4s8 commented Nov 22, 2021

Actions workflow https://github.com/artipie/ppom/blob/master/.github/workflows/verify.yaml was added to verify all Artipie modules on pom changes. It uses https://github.com/artipie/ppom/blob/master/scripts/verify.sh script to compile source and test. It could be used locally with ./scripts/verify artipie/adapter-name.

Some adapters are missed here, we need to add all modules to verify on build.

@artipie/members - please check this issue and add adapters you are maintaining.

@ChGen
Copy link
Contributor

ChGen commented Nov 22, 2021

@g4s8 , should we add similar files to other adapters manually and check the scripts?

@g4s8
Copy link
Member Author

g4s8 commented Nov 22, 2021

@g4s8 , should we add similar files to other adapters manually and check the scripts?

@ChGen no, just put job to the list of jobs description, add additional configuration if needed, e.g. see job for `npm-adapter:

  npm-adapter:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - name: Set up JDK
        uses: actions/setup-java@v2
        with:
          distribution: adopt
          java-version: 17
      - name: Verify
        run: ./scripts/verify.sh artipie/npm-adapter

@ChGen
Copy link
Contributor

ChGen commented Nov 22, 2021

@g4s8 , but for local verification with ./scripts/verify artipie/adapter-name some scripts must be added to the adapter repository anyway. Is it correct?

@g4s8
Copy link
Member Author

g4s8 commented Nov 22, 2021

@g4s8 , but for local verification with ./scripts/verify artipie/adapter-name some scripts must be added to the adapter repository anyway. Is it correct?

@ChGen no, you just need some standard environment for building java project (Maven, Java, git). This script doesn't run any test, it only compile source and test using local parent snapshot

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants