Skip to content

Commit

Permalink
metal : fix ggml_metal_supports_op for BF16 (ggerganov#8021)
Browse files Browse the repository at this point in the history
Currently the Metal backend does not support BF16. `ggml_metal_supports_op` was returning true in these cases, leading to a crash with models converted with `--leave-output-tensor`. This commit checks if the first few sources types are BF16 and returns false if that's the case.
  • Loading branch information
mdegans authored Jun 20, 2024
1 parent ba58993 commit 2075a66
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions ggml-metal.m
Original file line number Diff line number Diff line change
Expand Up @@ -735,6 +735,12 @@ static void ggml_metal_free(struct ggml_metal_context * ctx) {
}

static bool ggml_metal_supports_op(const struct ggml_metal_context * ctx, const struct ggml_tensor * op) {
for (size_t i = 0, n = 3; i < n; ++i) {
if (op->src[i] != NULL && op->src[i]->type == GGML_TYPE_BF16) {
return false;
}
}

switch (op->op) {
case GGML_OP_UNARY:
switch (ggml_get_unary_op(op)) {
Expand Down

0 comments on commit 2075a66

Please sign in to comment.