Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename initState to callback in atom overload #822

Open
wants to merge 1 commit into
base: v3
Choose a base branch
from
Open

fix: rename initState to callback in atom overload #822

wants to merge 1 commit into from

Conversation

qweered
Copy link

@qweered qweered commented Apr 21, 2024 •
edited
Loading

Before

IMG_20240422_033251_682.jpg

After

IMG_20240422_033252_517.jpg

IMG_20240422_033256_203.jpg

@stackblitz StackBlitz
Copy link

stackblitz bot commented Apr 21, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel Vercel
Copy link

vercel bot commented Apr 21, 2024

@qweered is attempting to deploy a commit to the artalar's projects Team on Vercel.

A member of the Team first needs to authorize it.

BANOnotIT
BANOnotIT requested changes Apr 22, 2024
View reviewed changes
packages/core/src/atom.ts
@@ -671,7 +671,7 @@ function onCall(this: Action, cb: Fn): Unsubscribe {
})
}

export function atom<T>(initState: (ctx: CtxSpy) => T, name?: string): Atom<T>
export function atom<T>(callback: (ctx: CtxSpy) => T, name?: string): Atom<T>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here are my options:

  • reducer, because the second argument is the previous state
  • computer, because when we pass a function we turn an atom into a computed atom

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@artalar

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

computed is the right name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artalar artalar artalar left review comments

@BANOnotIT BANOnotIT BANOnotIT requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qweered @BANOnotIT @artalar