Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request::execute is throwable but does not throw #15

Open
Thiryn opened this issue May 3, 2018 · 0 comments
Open

Request::execute is throwable but does not throw #15

Thiryn opened this issue May 3, 2018 · 0 comments

Comments

@Thiryn
Copy link

Thiryn commented May 3, 2018 •
edited
Loading

The Request::execute function is maked as thowing, but it is not throwing anything. In fact the try resource?.documentDictionary() does not throw either, so the try could be removed. Then the throws for Request:result can be removed as well allowing to lighten calls to APIs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Thiryn