Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor out pmu_device functionality out of user-request #35

Open
PrzemekWirkus opened this issue Oct 14, 2024 · 0 comments · May be fixed by #76
Open

Refactor out pmu_device functionality out of user-request #35

PrzemekWirkus opened this issue Oct 14, 2024 · 0 comments · May be fixed by #76
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@PrzemekWirkus
Copy link
Collaborator

Cloned for: https://linaro.atlassian.net/browse/WPERF-798

  • Unfortunately user_request knows about events and metrics. It shouldn’t.
  • At best user_request class while parsing metrics, events etc. should know their names. Shouldn’t generate events more complex data for pmu_device.

https://github.com/arm-developer-tools/windowsperf/blob/main/wperf/user_request.cpp

Definition of Done

  • Remove from user_request functionality that requires it to know about metrics and events.
@PrzemekWirkus PrzemekWirkus added the enhancement New feature or request label Oct 14, 2024
@PrzemekWirkus PrzemekWirkus added the good first issue Good for newcomers label Nov 1, 2024
This was referenced Nov 27, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Integrate arg parser nader-zouaoui/windowsperf
1 participant
@PrzemekWirkus