Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move categories sanitization to a pydantic before_validator #866

Open
mtache opened this issue Oct 10, 2024 · 1 comment
Open

Move categories sanitization to a pydantic before_validator #866

mtache opened this issue Oct 10, 2024 · 1 comment
Labels
framework-enhancement New feature or request
Milestone

Comments

@mtache
Copy link
Collaborator

mtache commented Oct 10, 2024

Consider moving categories sanitization to a pydantic before_validator to improve performances.
See benchmarks in #861

@mtache mtache added the framework-enhancement New feature or request label Oct 10, 2024
@mtache mtache added this to the v2.0.0 milestone Oct 10, 2024
@gmuloc
Copy link
Collaborator

gmuloc commented Oct 10, 2024

  • Create an ENUM for categories
  • Update tests to use the valid names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework-enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants