Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor benchmarks for feature handling #365

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

huitseeker
Copy link
Contributor

Helps with argumentcomputer/ci-workflows#49

  • Renamed several environmental variables in various benchmarking scripts and configuration files for consistency.
  • Introduced a new section for performing comparative benchmarks based on respective features and architecture.
  • Added a new variable to the default benchmark configuration, BENCH_OUTPUT, set to commit-comment.

Copy link
Member

@samuelburnham samuelburnham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to remove the ARECIBO prefix for env vars in the gpu-bench.yml and bench-pr-comment.yml workflows.

Once merged these changes would also do well in lurk-rs, I can help as needed

benches/justfile Show resolved Hide resolved
Helps with argumentcomputer/ci-workflows#49

- Renamed several environmental variables in various benchmarking scripts and configuration files for consistency.
- Introduced a new section for performing comparative benchmarks based on respective features and architecture.
- Added a new variable to the default benchmark configuration, `BENCH_OUTPUT`, set to `commit-comment`.
@huitseeker huitseeker added this pull request to the merge queue Mar 18, 2024
Merged via the queue into argumentcomputer:dev with commit b4bfe89 Mar 18, 2024
10 checks passed
@huitseeker huitseeker deleted the improve_justfile branch March 18, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants