Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible issue with validation set creation? #32

Open
pierotofy opened this issue Aug 30, 2023 · 0 comments
Open

Possible issue with validation set creation? #32

pierotofy opened this issue Aug 30, 2023 · 0 comments

Comments

@pierotofy
Copy link
Contributor

pierotofy commented Aug 30, 2023

I was giving a good read to https://github.com/argosopentech/argos-train/blob/master/argostrain/data.py#L21 and noticed that the input is not shuffled.

Shouldn't the the input should be shuffled to have a better distribution? For example, if your first source is a wiktionary dataset, the program would be validating the dataset only against single word translations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant