Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added a migration file to include a position column in the
mediable
andfileable
tables, enabling the retrieval of items in a specific order based on their position.Additionally, there is a bug in the
$this->attachNew($records, $current, false)
method when updating existing pivot records. The issue arises because:This code uses the
relatedPivotKey
(such asmedia_id
orfile_id
) to locate the record for updating. However, in our case, the IDs passed to this method are the IDs of the pivot table itself, notmedia_id
orfile_id
. To resolve this, I overrode theattachNew
method and filtered by the pivot table ID:Related Issues
Fixes #2690 , #2689