This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Fixed #98 by removing camelCasing of library names #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrPointer
suggested changes
Feb 12, 2020
| @@ -1,3 +1,4 @@ | |||
| set(CMAKE_TOOLCHAIN_FILE ../cmake/Arduino-Toolchain.cmake) | |||
There was a problem hiding this comment.
Unnecessary, please remove this line
| @@ -27,10 +27,6 @@ function(find_arduino_library _target_name _library_name) | |||
|
|
|||
| is_platform_library(${_library_name} is_plib) # Detect whether library is a platform library | |||
|
|
|||
| if (NOT parsed_args_3RD_PARTY AND NOT is_plib) | |||
There was a problem hiding this comment.
I'm afraid you can't simply delete this block.
It's been a long time since I've written any code in this project, so I don't exactly remember the details, but I do remember that this is important, for other libraries.
You've got to find another way around this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CamelCasing of library names caused issues with using the built-in SD library. I removed it, and fixed up the case where the stepper library example did not match that in the wiki docs. I also added an example with the SD library linked to act as a regression test.
This change might break existing code that uses the CamelCasing feature.