Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is.number returns True for Infinity and -Infinity #308

Open
ironmaniiith opened this issue May 7, 2020 · 2 comments
Open

is.number returns True for Infinity and -Infinity #308

ironmaniiith opened this issue May 7, 2020 · 2 comments

Comments

@ironmaniiith
Copy link
Collaborator

ironmaniiith commented May 7, 2020

The method is.number before #307 returns True in case of Infinity and -Infinity, which is something that might not be expected.

Though typeof(Infinity) in JS returns "number", this might not be what devs are expecting when they are using is.number

This has already been updated with this commit

@ironmaniiith
Copy link
Collaborator Author

@jdalton , what is your opinion on this? Should we stick to the old behaviour or change the definition of is.number for Infinity and -Infinity

@evdama
Copy link

evdama commented Mar 18, 2022

This one can be closed as it's solved by #307 plus I've forked and upgraded the entire repo to ES6 plus in the progress also merged the tests for Infinity evdama@ba8cb0b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants