Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function name collisions for Aragon Apps #598

Open
bingen opened this issue Jul 22, 2020 · 0 comments
Open

Function name collisions for Aragon Apps #598

bingen opened this issue Jul 22, 2020 · 0 comments
Assignees

Comments

@bingen
Copy link
Contributor

bingen commented Jul 22, 2020

No Aragon App will be able to use any of the following function/variable names, because they fall under the AppProxy* contracts in the inheritance graph, and therefore the fallback with the delegated call is not reached if one of them is called:

  • kernel
  • appId
  • setKernel
  • setAppId
  • implementation
  • proxyType
  • setPinnedCode
  • pinnedCode
  • getAppBase
  • delegatedFwd
  • isContract

It’s probably not a big deal, as it doesn’t seem so likely, some of them belong to standards, and anyway the workaround is so easy as changing the name, but we should document it.
It would have been nice to prefix them all, except the standard ones, with a prefix like aOs, but I don’t think the breaking change is now worth it.

For reference, it was motivated by this comment: #597 (comment)

@bingen bingen self-assigned this Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant