Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AQLBlessures: Fix player removal lookup #8

Open
BilliAlpha opened this issue Aug 30, 2022 · 0 comments
Open

AQLBlessures: Fix player removal lookup #8

BilliAlpha opened this issue Aug 30, 2022 · 0 comments
Labels
code review Something isn't right in the code and should be fixed

Comments

@BilliAlpha
Copy link
Member

Following 5fdc223 the loop should follow the early return style. this means the condition should be inverted to continue when the player name isn't the one expected. Then when the right player is found and stored we should break out of the loop.
@BilliAlpha BilliAlpha added the code review Something isn't right in the code and should be fixed label Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code review Something isn't right in the code and should be fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BilliAlpha