Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically fill --announce flag on filc deal subcommand #69

Open
elijaharita opened this issue Apr 20, 2022 · 0 comments
Open

Automatically fill --announce flag on filc deal subcommand #69

elijaharita opened this issue Apr 20, 2022 · 0 comments
Assignees
@elijaharita

Comments

@elijaharita
Copy link
Contributor

When the boost PR merges, filc users will need to fill the --announce flag with /ip4/[public ip]/tcp/6755 when making deals. This is pretty un-discoverable for general users, and I don't think there's any reason not to just abstract this away in most cases.

It's fine just to do this at the filc level. This feature is mainly for CLI accessibility. The main filclient library can continue to require this field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elijaharita elijaharita

Labels
None yet
Projects
Filclient Task Board
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elijaharita