Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return retrieval stats even after failure #33

Open
elijaharita opened this issue Nov 20, 2021 · 1 comment
Open

Return retrieval stats even after failure #33

elijaharita opened this issue Nov 20, 2021 · 1 comment
Assignees
Labels
New Feature New feature or request Stale

Comments

@elijaharita
Copy link
Contributor

If a retrieval starts and then fails, we still want to know how long we spent, how much FIL we paid, how much was received, etc. Right now, we just return an error that says uh oh something went wrong!

We will probably want to rename RetrievalStats to RetrievalResult, and if a retrieval fails partway through, instead of returning a non-nil error, we will fill out the RetrievalResult and include an Outcome value or Err error inside of the struct.

Planned like this because returning valid data along with a non-nil error in the return tuple is weird and unexpected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature New feature or request Stale
Projects
Status: Backlog
Development

No branches or pull requests

2 participants