Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render deal status icon with link to staging zone if in staged status #146

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

neelvirdy
Copy link
Contributor

blocked on:

  1. populating DealStatus in util.Content
  2. making zoneId available in util.Content, or changing the /staging-zones/:id param to accept the zone content id instead of the zone id

@neelvirdy neelvirdy mentioned this pull request Dec 16, 2022
10 tasks
<SafetyCheckOutlined color="warning" fontSize="small" className={styles.statusIcon} />
</Tooltip>
);
}
Copy link
Contributor

@en0ma en0ma Dec 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need 2 more - slashed and expired

@en0ma
Copy link
Contributor

en0ma commented Dec 17, 2022

  1. making zoneId available in util.Content, or changing the /staging-zones/:id param to accept the zone content id instead of the zone id

Let's get @alvin-reyes to add a new int column(zone_id - with index) at the end of the content table (so it will be fast). I realized I need this too, as the reconstruction pulls in contents it has not added to the zone yet.

  1. populating DealStatus in util.Content

The same thing, we can get @alvin-reyes to another column for deal_status at the end of the content table

@en0ma
Copy link
Contributor

en0ma commented Dec 17, 2022

@neelvirdy I was thinking about the deal status, that is going to be a bit tricky to pull off if we consider that content to a deal has a 1-to-many relationship and not a 1-to-1. So the question is, how do you want to display the status of all the 6 deals of a particular content?

@neelvirdy
Copy link
Contributor Author

@neelvirdy I was thinking about the deal status, that is going to be a bit tricky to pull off if we consider that content to a deal has a 1-to-many relationship and not a 1-to-1. So the question is, how do you want to display the status of all the 6 deals of a particular content?

for the initial version i want to keep it simple and use the "lowest" status of the 6. so you would be in proposing until all 6 are accepted, for example.

for the next version, we can make the tooltip include counts like: "transfering (2 / 6)" where it shows how many of the deals are done with that "lowest" status.

after that, we should have a page for the set of deals pertaining to a content. so we could make the icon a link to that detailed page where you essentially get what's currently rendered on the Deals page, but just for that content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants