-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render deal status icon with link to staging zone if in staged status #146
base: master
Are you sure you want to change the base?
Render deal status icon with link to staging zone if in staged status #146
Conversation
<SafetyCheckOutlined color="warning" fontSize="small" className={styles.statusIcon} /> | ||
</Tooltip> | ||
); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need 2 more - slashed
and expired
Let's get @alvin-reyes to add a new int column(
The same thing, we can get @alvin-reyes to another column for |
@neelvirdy I was thinking about the deal status, that is going to be a bit tricky to pull off if we consider that content to a deal has a 1-to-many relationship and not a 1-to-1. So the question is, how do you want to display the status of all the 6 deals of a particular content? |
for the initial version i want to keep it simple and use the "lowest" status of the 6. so you would be in for the next version, we can make the tooltip include counts like: "transfering (2 / 6)" where it shows how many of the deals are done with that "lowest" status. after that, we should have a page for the set of deals pertaining to a content. so we could make the icon a link to that detailed page where you essentially get what's currently rendered on the Deals page, but just for that content. |
blocked on: