Skip to content
This repository has been archived by the owner on May 15, 2023. It is now read-only.

test generation for xml mediatype converting body to json to check schema #168

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

SrHuevo
Copy link
Contributor

@SrHuevo SrHuevo commented Mar 5, 2018

I need to validate the body response when the response produces a XML mime type.

To do this, I transform the xml body response to json with xml2js module and I validate against the json scheme generated for swagger definition. In the same way that it was done when it was a json mime type.

I have added tests for check this feature (test/xmlConsumeTypeTest)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

@SrHuevo
Copy link
Contributor Author

SrHuevo commented Mar 5, 2018

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@SrHuevo
Copy link
Contributor Author

SrHuevo commented Mar 5, 2018

I just changed the email of the user commiter

@googlebot
Copy link

CLAs look good, thanks!

lib/helpers.js Outdated
@@ -77,6 +80,23 @@ function isJsonMediaType(type, options) {
return mediaTypeContainsJson(type) ? options.fn(this) : options.inverse(this);
}

/**
* mustache helper method to determine if a mediaType is JSON
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description is a copy and paste of another function

lib/helpers.js Outdated
}

/**
* mustache helper method to determine if a mediaType is JSON
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description is a copy and paste of another function

@SrHuevo
Copy link
Contributor Author

SrHuevo commented Mar 7, 2018

sorry, I just changed it and amended

@SrHuevo
Copy link
Contributor Author

SrHuevo commented Mar 9, 2018

I just added the possibility of setting a config for the module xml2js through the config param of the gentest function

@SrHuevo SrHuevo force-pushed the master branch 2 times, most recently from 8983784 to 38d1a79 Compare March 27, 2018 13:14
@noahdietz
Copy link
Contributor

Hey @SrHuevo I'm sorry but I've merged a couple of other changes and now there are some merge conflicts. Furthermore, some of the CI checks failed. The checks are just running npm test, so this is something you can resolve yourself.

If you are willing to resolve the conflicts and fix the tests, I'd still appreciate your contribution. Thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants