New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JSONSchema] Type factory breaks compatibility in 3.4 #6753

Open

soyuka opened this issue Oct 25, 2024 · 1 comment

Member

soyuka commented Oct 25, 2024

API Platform version(s) affected: 3.4

See #5897 this should've been removed from 4.0, not 3.4:

core/src/Symfony/Bundle/Resources/config/json_schema.xml

Lines 17 to 20 in fc8fa00

    
           <service id="api_platform.json_schema.schema_factory" class="ApiPlatform\JsonSchema\SchemaFactory"> 
        
               <argument>null</argument> 
        
               <argument type="service" id="api_platform.metadata.resource.metadata_collection_factory" />

Therefore there's a BC Break.

Side note: we should document #5897 (comment) as a replacement for TypeFactoryInterface.

Contributor

bendavies commented Oct 25, 2024

and ApiPlatform\OpenApi\Factory\OpenApiFactory is broken the same way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment