-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-49797][INFRA] Align the running OS image of maven_test.yml
to ubuntu-latest
#48263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o `ubuntu-latest`
cc @HyukjinKwon |
dongjoon-hyun
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Yes, I agree with this direction. It would be okay except the mentioned two TPCDS gen jobs.
Merged to master. Thank you, @panbingkun and @HyukjinKwon . |
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
…o `ubuntu-latest` ### What changes were proposed in this pull request? The pr aims to align the running OS image of `maven_test.yml` to `ubuntu-latest` (from `ubuntu-22.04` to `ubuntu-24.04`) ### Why are the changes needed? https://github.com/actions/runner-images/releases/tag/ubuntu24%2F20240922.1 <img width="627" alt="image" src="https://github.com/user-attachments/assets/f42fd7ed-c52a-4b39-9a92-02657c53d734"> After actions/runner-images#10636, `ubuntu-latest` has already pointed to `ubuntu-24.04` instead of `ubuntu-22.04`. <img width="811" alt="image" src="https://github.com/user-attachments/assets/adf6b3a8-5ca5-4daa-b35d-ea1386fa07a6"> I have checked all tasks running on `Ubuntu OS` (except for the 2 related to `TPCDS`), and they are all using `ubuntu-latest`. Currently, only `maven_test.yml` is using `ubuntu-22.04`. Let's align it. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48263 from panbingkun/SPARK-49797. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
…o `ubuntu-latest` ### What changes were proposed in this pull request? The pr aims to align the running OS image of `maven_test.yml` to `ubuntu-latest` (from `ubuntu-22.04` to `ubuntu-24.04`) ### Why are the changes needed? https://github.com/actions/runner-images/releases/tag/ubuntu24%2F20240922.1 <img width="627" alt="image" src="https://github.com/user-attachments/assets/f42fd7ed-c52a-4b39-9a92-02657c53d734"> After actions/runner-images#10636, `ubuntu-latest` has already pointed to `ubuntu-24.04` instead of `ubuntu-22.04`. <img width="811" alt="image" src="https://github.com/user-attachments/assets/adf6b3a8-5ca5-4daa-b35d-ea1386fa07a6"> I have checked all tasks running on `Ubuntu OS` (except for the 2 related to `TPCDS`), and they are all using `ubuntu-latest`. Currently, only `maven_test.yml` is using `ubuntu-22.04`. Let's align it. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48263 from panbingkun/SPARK-49797. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to align the running OS image of
maven_test.yml
toubuntu-latest
(fromubuntu-22.04
toubuntu-24.04
)Why are the changes needed?
https://github.com/actions/runner-images/releases/tag/ubuntu24%2F20240922.1
After actions/runner-images#10636,
ubuntu-latest
has already pointed toubuntu-24.04
instead ofubuntu-22.04
.I have checked all tasks running on
Ubuntu OS
(except for the 2 related toTPCDS
), and they are all usingubuntu-latest
. Currently, onlymaven_test.yml
is usingubuntu-22.04
. Let's align it.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.