Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-49797][INFRA] Align the running OS image of maven_test.yml to ubuntu-latest #48263

Closed
wants to merge 1 commit into from

Conversation

panbingkun
Copy link
Contributor

@panbingkun panbingkun commented Sep 26, 2024

What changes were proposed in this pull request?

The pr aims to align the running OS image of maven_test.yml to ubuntu-latest (from ubuntu-22.04 to ubuntu-24.04)

Why are the changes needed?

https://github.com/actions/runner-images/releases/tag/ubuntu24%2F20240922.1
image
After actions/runner-images#10636, ubuntu-latest has already pointed to ubuntu-24.04 instead of ubuntu-22.04.
image
I have checked all tasks running on Ubuntu OS (except for the 2 related to TPCDS), and they are all using ubuntu-latest. Currently, only maven_test.yml is using ubuntu-22.04. Let's align it.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the INFRA label Sep 26, 2024
@panbingkun panbingkun closed this Sep 26, 2024
@panbingkun panbingkun reopened this Sep 26, 2024
@panbingkun panbingkun marked this pull request as ready for review September 26, 2024 10:56
@panbingkun
Copy link
Contributor Author

cc @HyukjinKwon

@HyukjinKwon
Copy link
Member

cc @dongjoon-hyun

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Yes, I agree with this direction. It would be okay except the mentioned two TPCDS gen jobs.

@dongjoon-hyun
Copy link
Member

Merged to master. Thank you, @panbingkun and @HyukjinKwon .

attilapiros pushed a commit to attilapiros/spark that referenced this pull request Oct 4, 2024
…o `ubuntu-latest`

### What changes were proposed in this pull request?
The pr aims to align the running OS image of `maven_test.yml` to `ubuntu-latest` (from `ubuntu-22.04` to `ubuntu-24.04`)

### Why are the changes needed?
https://github.com/actions/runner-images/releases/tag/ubuntu24%2F20240922.1
<img width="627" alt="image" src="https://github.com/user-attachments/assets/f42fd7ed-c52a-4b39-9a92-02657c53d734">
After actions/runner-images#10636, `ubuntu-latest` has already pointed to `ubuntu-24.04` instead of `ubuntu-22.04`.
<img width="811" alt="image" src="https://github.com/user-attachments/assets/adf6b3a8-5ca5-4daa-b35d-ea1386fa07a6">
I have checked all tasks running on `Ubuntu OS` (except for the 2 related to `TPCDS`), and they are all using `ubuntu-latest`. Currently, only `maven_test.yml` is using `ubuntu-22.04`. Let's align it.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Pass GA.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes apache#48263 from panbingkun/SPARK-49797.

Authored-by: panbingkun <panbingkun@baidu.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
himadripal pushed a commit to himadripal/spark that referenced this pull request Oct 19, 2024
…o `ubuntu-latest`

### What changes were proposed in this pull request?
The pr aims to align the running OS image of `maven_test.yml` to `ubuntu-latest` (from `ubuntu-22.04` to `ubuntu-24.04`)

### Why are the changes needed?
https://github.com/actions/runner-images/releases/tag/ubuntu24%2F20240922.1
<img width="627" alt="image" src="https://github.com/user-attachments/assets/f42fd7ed-c52a-4b39-9a92-02657c53d734">
After actions/runner-images#10636, `ubuntu-latest` has already pointed to `ubuntu-24.04` instead of `ubuntu-22.04`.
<img width="811" alt="image" src="https://github.com/user-attachments/assets/adf6b3a8-5ca5-4daa-b35d-ea1386fa07a6">
I have checked all tasks running on `Ubuntu OS` (except for the 2 related to `TPCDS`), and they are all using `ubuntu-latest`. Currently, only `maven_test.yml` is using `ubuntu-22.04`. Let's align it.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Pass GA.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes apache#48263 from panbingkun/SPARK-49797.

Authored-by: panbingkun <panbingkun@baidu.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants