Fix write response metadata field(measure/stream) (#330)

apache · Sep 17, 2023 · 8996af5 · 8996af5
1 parent 9552688
commit 8996af5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/api/proto/banyandb/measure/v1/write.proto b/api/proto/banyandb/measure/v1/write.proto
@@ -55,7 +55,7 @@ message WriteResponse {
   // status indicates the request processing result
   model.v1.Status status = 2 [(validate.rules).enum.defined_only = true];
   // the metadata from request when request fails
-  common.v1.Metadata metadata = 3 [(validate.rules).message.required = true];
+  common.v1.Metadata metadata = 3;
 }
 
 message InternalWriteRequest {

diff --git a/api/proto/banyandb/stream/v1/write.proto b/api/proto/banyandb/stream/v1/write.proto
@@ -54,7 +54,7 @@ message WriteResponse {
   // status indicates the request processing result
   model.v1.Status status = 2 [(validate.rules).enum.defined_only = true];
   // the metadata from request when request fails
-  common.v1.Metadata metadata = 3 [(validate.rules).message.required = true];
+  common.v1.Metadata metadata = 3;
 }
 
 message InternalWriteRequest {

diff --git a/banyand/liaison/grpc/stream.go b/banyand/liaison/grpc/stream.go
@@ -99,7 +99,7 @@ func (s *streamService) Write(stream streamv1.StreamService_WriteServer) error {
 		entity, tagValues, shardID, err := s.navigate(writeEntity.GetMetadata(), writeEntity.GetElement().GetTagFamilies())
 		if err != nil {
 			s.sampled.Error().Err(err).RawJSON("written", logger.Proto(writeEntity)).Msg("failed to navigate to the write target")
-			reply(nil, modelv1.Status_STATUS_INTERNAL_ERROR, writeEntity.GetMessageId(), stream, s.sampled)
+			reply(writeEntity.GetMetadata(), modelv1.Status_STATUS_INTERNAL_ERROR, writeEntity.GetMessageId(), stream, s.sampled)
 			continue
 		}
 		if s.ingestionAccessLog != nil {