[Feature][Clickhouse] Support sink savemode #8086
Open
+2,029
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
reviewed
Nov 20, 2024
Comment on lines
+202
to
+203
| options.put("username", readonlyConfig.get(USERNAME)); | ||
| options.put("password", readonlyConfig.get(PASSWORD)); |
There was a problem hiding this comment.
please do not put username/password into options.
| @@ -63,6 +63,7 @@ public class ClickhouseSinkWriter | |||
| this.proxy = new ClickhouseProxy(option.getShardMetadata().getDefaultShard().getNode()); | |||
| this.shardRouter = new ShardRouter(proxy, option.getShardMetadata()); | |||
| this.statementMap = initStatementMap(); | |||
| System.out.println(123); | |||
Comment on lines
+43
to
+64
| if (tableSchema.getPrimaryKey() != null) { | ||
| primaryKey = | ||
| tableSchema.getPrimaryKey().getColumnNames().stream() | ||
| .map(r -> "`" + r + "`") | ||
| .collect(Collectors.joining(",")); | ||
| } | ||
| String uniqueKey = ""; | ||
| if (!tableSchema.getConstraintKeys().isEmpty()) { | ||
| uniqueKey = | ||
| tableSchema.getConstraintKeys().stream() | ||
| .flatMap(c -> c.getColumnNames().stream()) | ||
| .map(r -> "`" + r.getColumnName() + "`") | ||
| .collect(Collectors.joining(",")); | ||
| } | ||
| SqlTemplate.canHandledByTemplateWithPlaceholder( | ||
| template, | ||
| SaveModePlaceHolder.ROWTYPE_PRIMARY_KEY.getPlaceHolder(), | ||
| primaryKey, | ||
| TablePath.of(database, table).getFullName(), | ||
| ClickhouseConfig.SAVE_MODE_CREATE_TEMPLATE.key()); | ||
| template = | ||
| template.replaceAll( |
There was a problem hiding this comment.
how about put template parse into common module? Not only one connector use same logic.
|
|
||
| public class CreateTableParser { | ||
|
|
||
| private static final Pattern COLUMN_PATTERN = Pattern.compile("`?(\\w+)`?\\s*([\\w|\\W]*)"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
close #8060
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.