fix: multiple patches during long running tests for LMQ over RocksDB #8915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
lizhanhui
requested review from
RongtongJin,
tianliuliu,
DongyuanPan and
fuyou001
tianliuliu
reviewed
Nov 14, 2024
store/src/main/java/org/apache/rocketmq/store/rocksdb/RocksDBOptionsFactory.java
Show resolved
Hide resolved
RongtongJin
reviewed
Nov 14, 2024
store/src/main/java/org/apache/rocketmq/store/queue/RocksGroupCommitService.java
Outdated
Show resolved
Hide resolved
store/src/main/java/org/apache/rocketmq/store/queue/RocksDBConsumeQueueStore.java
Outdated
Show resolved
Hide resolved
fuyou001
reviewed
Nov 14, 2024
| private void accountWriteOpsForWalFlush() throws RocksDBException { | ||
| int writeCount = writeOpsCounter.incrementAndGet(); | ||
| if (writeCount >= messageStoreConfig.getRocksdbFlushWalFrequency()) { | ||
| this.db.flushWal(false); |
There was a problem hiding this comment.
may be flushWal(true) better
There was a problem hiding this comment.
The frequency of commit-offset may be very high, I prefer to keep this periodic flush async.
store/src/main/java/org/apache/rocketmq/store/queue/RocksGroupCommitService.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/apache/rocketmq/common/config/AbstractRocksDBStorage.java
Show resolved
Hide resolved
…Store#findConsumeQueueMap override Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
RongtongJin
previously approved these changes
Nov 15, 2024
fuyou001
previously approved these changes
Nov 17, 2024
|
Tests in error: |
tianliuliu
previously approved these changes
Nov 19, 2024
Got a few pretty busy days, I would fix it when I got some bandwidth |
Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
lizhanhui
dismissed stale reviews from tianliuliu, fuyou001, and RongtongJin
via
36b3ee2
Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
To #8829
Brief Description
How Did You Test This Change?