From 53cbb74284009dcedf128eda40d8a7730d44901f Mon Sep 17 00:00:00 2001
From: Jacques Le Roux <jacques.le.roux@les7arts.com>
Date: Tue, 29 Oct 2024 11:15:17 +0100
Subject: [PATCH] Improved: Fix some bugs SpotBugs reports (OFBIZ-12386)

  After https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=33fc03fa10

  I thought the problem was fixed since it's excluded. But it was not because
  there was a typo (a trailing blank in
  <Bug pattern="SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR " />)

  So I fixed that, but to my surprise it still does not work, weird :/

Completes previous commit. The reason was that the whole class was concerned.
---
 spotbugs/exclude.xml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/spotbugs/exclude.xml b/spotbugs/exclude.xml
index bd57d274fa..de48b2557b 100644
--- a/spotbugs/exclude.xml
+++ b/spotbugs/exclude.xml
@@ -193,9 +193,8 @@ under the License.
     <Bug pattern="EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS" />
   </Match><!-- ^ ^ not a problem, false positives -->
   <Match>
-    <!-- As it's also used by WebAppCacheTest class I made it package. That's safer but not enough as private so it's here -->
+    <!-- As it's also used by WebAppCacheTest class I made it package. That's safer but not enough as private so it's here with the whole class-->
     <Class name="org.apache.ofbiz.webapp.WebAppCache" />
-    <Method name="WebAppCache" />
     <Bug pattern="SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR" />
   </Match>
 </FindBugsFilter>