Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenRewrite for automatic code cleanup #6217

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vlsi
Copy link
Collaborator

@vlsi vlsi commented Jan 4, 2024

Description

This enables automatic migrations and code cleanup

"removeUnusedImports" in google-java-format is not supported with Java 17+ (it requires add-opens),
so move the fix to OpenRewrite
@vlsi
Copy link
Collaborator Author

vlsi commented Jan 10, 2024

It looks like OpenRewrite does not support mixed Java-Kotlin projects, so it can't parse Java files that call Kotlin classes:

jmeter/src/jorphan/src/main/java/org/apache/jorphan/gui/JFactory.java:111: error: cannot find symbol
    public static JEditableCheckBox small(JEditableCheckBox component) {
                  ^
  symbol:   class JEditableCheckBox
  location: class JFactory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant