Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate commons-lang usages to commons-lang3 #17130

Closed
kgyrtkirk opened this issue Sep 23, 2024 · 3 comments
Closed

Migrate commons-lang usages to commons-lang3 #17130

kgyrtkirk opened this issue Sep 23, 2024 · 3 comments
Labels
Contributions Welcome Feature/Change Description

Comments

@kgyrtkirk
Copy link
Member

  • Both commons-lang and commons-lang3 is being used in Druid
  • commons-lang does not get updates since 2011

I've started working on it a few months ago - I do remember there might be some stuff missing; but I wasn't able to get back to it; it would need to be merged with the current master - I guess there might be some new common-lang usages :)

my worktree is here
@shigarg1
Copy link
Contributor

Hi @kgyrtkirk
I would like to take this up. Will cherry-pick the commits from your tree and proceed from there.

@shigarg1 shigarg1 mentioned this issue Sep 25, 2024
Merged
@shigarg1
Copy link
Contributor

#17156
@kgyrtkirk Can you please help to review

@kgyrtkirk
Copy link
Member Author

#17156 is merged; thank you @shigarg1 !
I've opened/described the problem we have faced just before merging that PR #17208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Contributions Welcome Feature/Change Description
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kgyrtkirk @shigarg1