Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [C++] Add missing header for ORC adapter #44876

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

mikelui
Copy link
Contributor

@mikelui mikelui commented Nov 27, 2024

Rationale for this change

Very minor. This source file cannot be compiled on its own manually, due to missing stringstream headers. This fixes that. Otherwise we get implicit instantiation of undefined template errors.

Context is we build Apache Arrow in a separate build system, Buck. As such, we do not (and cannot) 100% mirror the CMake build. In the past we've also had to patch header issues like: 529e08c. Thus, this change is for posterity to avoid having to custom patches on every new release.

What changes are included in this PR?

Adds which is used here:
https://github.com/apache/arrow/blob/main/cpp/src/arrow/adapters/orc/util.cc#L1226

Are these changes tested?

N/A

Are there any user-facing changes?

No

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Nov 28, 2024
@kou kou changed the title MINOR: [C++] Add missing header for Orc adapter MINOR: [C++] Add missing header for ORC adapter Nov 28, 2024
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 857092c into apache:main Nov 28, 2024
41 of 42 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Nov 28, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Nov 28, 2024
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 857092c.

There were 132 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants