Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44729: [C++][Acero] Enable nested types for non-keys fields in AsofJoin operation #44871

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mroz45
Copy link
Contributor

@mroz45 mroz45 commented Nov 27, 2024

Rationale for this change

Add support for nested types

What changes are included in this PR?

Change unmnaterialized_table to use AppendArraySlice

Are these changes tested?

I added tests for case List, Fixed Size List and Struct

Are there any user-facing changes?

Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@kou kou changed the title GH-[44729]: [C++][Acero] Enable nested types for non-keys fields in AsofJoin operation GH-44729: [C++][Acero] Enable nested types for non-keys fields in AsofJoin operation Nov 28, 2024
Copy link

⚠️ GitHub issue #44729 has been automatically assigned in GitHub to PR creator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant