Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Parquet] Guard against use of decryptor/encryptor after wipe out #43946

Closed
pitrou opened this issue Sep 4, 2024 · 1 comment
Closed

[C++][Parquet] Guard against use of decryptor/encryptor after wipe out #43946

pitrou opened this issue Sep 4, 2024 · 1 comment
Assignees
@pitrou
Labels
Component: C++ Component: Parquet Type: enhancement
Milestone
18.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Sep 4, 2024

Describe the enhancement requested

According to #43057 (comment), in some cases a AesEncryptor or AesDecryptor might be used after its WipeOut method was called. This will typically produce a crash in OpenSSL. Instead, we might check whether the encryptor/decryptor was wiped out and error out.

Component(s)

C++, Parquet
pitrou added a commit to pitrou/arrow that referenced this issue Sep 4, 2024
@pitrou
apacheGH-43946: [C++][Parquet] Guard against use of decryptor/encrypt…
6630f7b 
…or after wipeout
pitrou added a commit to pitrou/arrow that referenced this issue Sep 4, 2024
@pitrou
apacheGH-43946: [C++][Parquet] Guard against use of decryptor/encrypt…
f206c0a 
…or after wipeout
@github-actions github-actions bot mentioned this issue Sep 4, 2024
Merged
pitrou added a commit to pitrou/arrow that referenced this issue Sep 4, 2024
@pitrou
apacheGH-43946: [C++][Parquet] Guard against use of decryptor/encrypt…
b253529 
…or after wipeout
pitrou added a commit to pitrou/arrow that referenced this issue Sep 4, 2024
@pitrou
apacheGH-43946: [C++][Parquet] Guard against use of decryptor/encrypt…
58b5daf 
…or after wipeout
pitrou added a commit to pitrou/arrow that referenced this issue Sep 5, 2024
@pitrou
apacheGH-43946: [C++][Parquet] Guard against use of decryptor/encrypt…
d2bcc8f 
…or after wipeout
pitrou added a commit that referenced this issue Sep 5, 2024
@pitrou
GH-43946: [C++][Parquet] Guard against use of cleared decryptor/encry…
032e6a4 
…ptor (#43947)

This is to get a clearer error rather than an obscure crash, see #43057 for an example.

* GitHub Issue: #43946

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou
Copy link
Member Author

pitrou commented Sep 5, 2024

Issue resolved by pull request 43947
#43947

@pitrou pitrou added this to the 18.0.0 milestone Sep 5, 2024
@pitrou pitrou closed this as completed Sep 5, 2024
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Sep 6, 2024
@pitrou @zanmato1984
apacheGH-43946: [C++][Parquet] Guard against use of cleared decryptor…
967ab83 
…/encryptor (apache#43947)

This is to get a clearer error rather than an obscure crash, see apache#43057 for an example.

* GitHub Issue: apache#43946

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
khwilson pushed a commit to khwilson/arrow that referenced this issue Sep 14, 2024
@pitrou @khwilson
apacheGH-43946: [C++][Parquet] Guard against use of cleared decryptor…
981b841 
…/encryptor (apache#43947)

This is to get a clearer error rather than an obscure crash, see apache#43057 for an example.

* GitHub Issue: apache#43946

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pitrou pitrou

Labels
Component: C++ Component: Parquet Type: enhancement
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
1 participant
@pitrou