only set zero if necessary

apache · Nov 5, 2024 · de5a74d · de5a74d
1 parent 76f3fc1
commit de5a74d
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthViewVector.java b/java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthViewVector.java
@@ -1367,10 +1367,6 @@ protected ArrowBuf allocateOrGetLastDataBuffer(int length) {
   protected final void setBytes(int index, byte[] value, int start, int length) {
     int writePosition = index * ELEMENT_SIZE;
 
-    // to clear the memory segment of view being written to
-    // this is helpful in case of overwriting the value
-    viewBuffer.setZero(writePosition, ELEMENT_SIZE);
-
     if (length <= INLINE_SIZE) {
       // allocate inline buffer
       // set length
@@ -1411,11 +1407,13 @@ protected final void setBytes(int index, byte[] value, int start, int length) {
   protected final void setBytes(int index, ArrowBuf valueBuf, int start, int length) {
     int writePosition = index * ELEMENT_SIZE;
 
-    // to clear the memory segment of view being written to
-    // this is helpful in case of overwriting the value
-    viewBuffer.setZero(writePosition, ELEMENT_SIZE);
-
     if (length <= INLINE_SIZE) {
+      // to clear the memory segment of view being written to
+      // if it has been set
+      if (viewBuffer.getLong(writePosition) != 0 || viewBuffer.getLong(writePosition + 8) != 0) {
+        viewBuffer.setZero(writePosition, ELEMENT_SIZE);
+      }
+
       // allocate inline buffer
       // set length
       viewBuffer.setInt(writePosition, length);