Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: request get Args params #310

Open
seesaws opened this issue Sep 12, 2024 · 0 comments
Open

bug: request get Args params #310

seesaws opened this issue Sep 12, 2024 · 0 comments

Comments

@seesaws
Copy link

seesaws commented Sep 12, 2024

Issue description

Environment

  • Operating System: Windows 11
  • JDK Version: 17
    *IDE: IntelliJ IDEA 2024.1.4U
  • APISIX Java Plugin Runner Version: 0.4.0
  • Maven Dependency
org.apache.apisix apisix-runner-starter 0.4.0

Minimal test code / Steps to reproduce the issue

When using the getArgs method of the org.apache.apisix.plugin.runner.HttpRequest class, the returned parameter type is Map<String, String>. The expected behavior is for it to return a parameter type consistent with the getParameterMap method of the jakarta.servlet.ServletRequestWrapper class, which is Map<String, String[]>.
Steps to Reproduce the Issue
Set the Maven dependency to apisix-runner-starter version 0.4.0.
Use the HttpRequest.getArgs() method in the APISIX Java Plugin to retrieve parameters.
Submit multiple parameters with the same key using a GET method or POST form.

What's the actual result? (including assertion message & call stack if applicable)

  • HttpRequest.getArgs() returns parameters as Map<String, String>.
  • When using GET or POST forms with multiple parameters having the same key, previous key-value pairs are lost, and only the last key-value pair is retained.

What's the expected result?

HttpRequest.getArgs() should return parameters as Map<String, String[]>, matching the behavior of jakarta.servlet.ServletRequestWrapper.getParameterMap() and correctly retaining all values for the same key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant