Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Random seed incorrectly set for CMAES optimizer #600

Open
CodingTragic opened this issue May 31, 2024 · 1 comment
Open

Bug: Random seed incorrectly set for CMAES optimizer #600

CodingTragic opened this issue May 31, 2024 · 1 comment
Assignees
Labels

Comments

@CodingTragic
Copy link

If the following is called, the seed is ignored.

algorithm = CMAES(popsize, ...)
algorithm.setup(problem, seed, termination)

The above setup method is located in base class Algorithm, which calls the _setup method of child class CMAES without providing the seed parameter, which is used to set a value of member "options"

Further, the setup method of base class Algorithm assigns an instance variable to the seed and thus providing the seed as a parameter is redundant - it can use the derived member "seed".

@blankjul
Copy link
Collaborator

blankjul commented Jun 2, 2024

Thanks for creating this issue.

Can you please check if the commit above fixed the problem?

@blankjul blankjul added the bug label Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants