feat(ava/advisor): add some meta info, includes 5 chart ckb, 2 purpos… #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e, 1 level of measure
Yzing
changed the base branch from
dev-refactor-pipeline2
to
refactor-advisor-pipeline
Yzing
changed the base branch from
refactor-advisor-pipeline
to
dev-refactor-pipeline2
chenluli
reviewed
Jul 8, 2024
| @@ -1,6 +1,25 @@ | |||
| import type { PureChartKnowledgeBase } from './types'; | |||
|
|
|||
| export const base: PureChartKnowledgeBase = { | |||
| indicator_chart: { | |||
There was a problem hiding this comment.
以前给指标卡预留过一个命名 kpi_panel ，可以用这个名字
| @@ -1,6 +1,25 @@ | |||
| import type { PureChartKnowledgeBase } from './types'; | |||
|
|
|||
| export const base: PureChartKnowledgeBase = { | |||
| indicator_chart: { | |||
| id: 'indicator_chart', | |||
| name: 'Value Chart', | |||
| name: 'Value Chart', | ||
| alias: ['Indicator'], | ||
| family: ['Indicators'], | ||
| def: 'A chart show indicator number, can', |
| shape: ['Other'], | ||
| encodePres: {}, | ||
| dataPres: [ | ||
| { minQty: 0, maxQty: 2, fieldConditions: ['Time', 'Ordinal', 'Nominal'] }, |
There was a problem hiding this comment.
不考虑在图表内进行数据聚合逻辑的话，指标卡好像不应该有维度？
ava 这里应该不考虑维度，有的话好像也不好限制 maxQty
| { minQty: 0, maxQty: 2, fieldConditions: ['Time', 'Ordinal', 'Nominal'] }, | ||
| { minQty: 1, maxQty: '*', fieldConditions: ['Interval'] }, | ||
| ], | ||
| channel: [], |
There was a problem hiding this comment.
channel 感觉可以加一个 'Text' ，用文本编码的数据
| shape: ['Bars'], | ||
| dataPres: [{ minQty: 1, maxQty: 2, fieldConditions: ['Interval'] }], | ||
| channel: ['Length'], | ||
| recRate: 'Not Recommended', |
| shape: ['Bars'], | ||
| dataPres: [ | ||
| { minQty: 1, maxQty: 2, fieldConditions: ['Interval'] }, | ||
| { minQty: 1, maxQty: 1, fieldConditions: ['Geo'] }, |
There was a problem hiding this comment.
地图类先不加好了，因为 fieldConditions 这里内置的还没有识别 Geo 类型的，所以这里加上了实际也推不出来，会有点问题
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e, 1 level of measure
PR includes