From 84ecba12195e6d3999cf3c3114e752d63bab9530 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Sat, 26 Nov 2022 12:18:00 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- .../pytorch_pretrained_bert/modeling.py | 21 ++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/scripts/experiments/intrinsic_evaluations/exbert/server/pytorch_pretrained_bert/modeling.py b/scripts/experiments/intrinsic_evaluations/exbert/server/pytorch_pretrained_bert/modeling.py index a51fec8..e8bb410 100644 --- a/scripts/experiments/intrinsic_evaluations/exbert/server/pytorch_pretrained_bert/modeling.py +++ b/scripts/experiments/intrinsic_evaluations/exbert/server/pytorch_pretrained_bert/modeling.py @@ -585,7 +585,26 @@ def from_pretrained(cls, pretrained_model_name_or_path, state_dict=None, cache_d logger.info("extracting archive file {} to temp dir {}".format( resolved_archive_file, tempdir)) with tarfile.open(resolved_archive_file, 'r:gz') as archive: - archive.extractall(tempdir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(archive, tempdir) serialization_dir = tempdir # Load config config_file = os.path.join(serialization_dir, CONFIG_NAME)